bazel: Add python envoy_entry_point
#19450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
with eg with i opened an upstream issue here bazelbuild/rules_python#600 |
phlax
force-pushed
the
bazel-python-entry-point
branch
from
bee9bc5 to
85449c8
Compare
This extends the `rules_python` `entry_point` to allow data to be added to the sandbox, and args to pass the data to the tool. Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
bazel-python-entry-point
branch
from
85449c8 to
d371022
Compare
|
this might be unnecessary, just thinking of another possible way to do it... |
which didnt work, so i think we want this PR |
htuch
reviewed
Jan 10, 2022
|
/wait |
Signed-off-by: Ryan Northey <ryan@synca.io>
htuch
pushed a commit
that referenced
this pull request
Jan 19, 2022
This is a follow up to use the macro added in #19450 for existing entry_points Also contains a fix to use a template to create the py_binary main to ensure the py_binary retains the path to the entry point Signed-off-by: Ryan Northey <ryan@synca.io>
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
This extends the rules_python entry_point to allow data to be added to the sandbox, and args to pass the data to the tool. Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Josh Perry <josh.perry@mx.com>
joshperry
pushed a commit
to joshperry/envoy
that referenced
this pull request
Feb 13, 2022
This is a follow up to use the macro added in envoyproxy#19450 for existing entry_points Also contains a fix to use a template to create the py_binary main to ensure the py_binary retains the path to the entry point Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Josh Perry <josh.perry@mx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the
rules_pythonentry_pointto allow data to beadded to the sandbox, and args to pass the data to the tool.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]